Update demoBERT input dimensions to match Triton requirement#1051
Merged
rajeevsrao merged 5 commits intoNVIDIA:masterfrom May 11, 2021
Merged
Update demoBERT input dimensions to match Triton requirement#1051rajeevsrao merged 5 commits intoNVIDIA:masterfrom
rajeevsrao merged 5 commits intoNVIDIA:masterfrom
Conversation
Collaborator
|
@mengdong this seems to be breaking the inference script. Can you please confirm? |
Contributor
Author
|
Yes, seems like we need to change the inference code for fixed seqlen model. |
Collaborator
|
@mengdong please rebase on NVIDIA:master. |
rajeevsrao
force-pushed
the
triton-bert
branch
2 times, most recently
from
27b0961 to
27d4680
Compare
mengdong
force-pushed
the
triton-bert
branch
2 times, most recently
from
cfe52ba to
ce910da
Compare
Signed-off-by: Dong Meng <dongm@nvidia.com> Signed-off-by: Rajeev Rao <rajeevrao@nvidia.com>
Signed-off-by: Rajeev Rao <rajeevrao@nvidia.com>
delete checkpoints Signed-off-by: Rajeev Rao <rajeevrao@nvidia.com>
Signed-off-by: Rajeev Rao <rajeevrao@nvidia.com>
Signed-off-by: Rajeev Rao <rajeevrao@nvidia.com>
rajeevsrao
changed the title
rajeevsrao
approved these changes
May 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @rajeevsrao, this is a similar change to #890, make builder generate an engine that works with Triton. I have tried 1 opt profile and multiple opt profiles and it seems to work well. Rebased based on the new master. I messed up last one due to a sign-off error